pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24042 )
Change subject: ms_amarisoft: extend AmariUE to support custom frequency bands ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24042/1/src/osmo_gsm_tester/obj/ms.py File src/osmo_gsm_tester/obj/ms.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24042/1/src/osmo_gsm_tester/obj/ms.py@38 PS1, Line 38: 'custom_band_list[].number': schema.UINT, do you plan to use all this with something else than Amarisoft? If only to be used by Amarisfot, then it makes sense to move it there probably. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24042/1/sysmocom/defaults.conf File sysmocom/defaults.conf: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24042/1/sysmocom/defaults.conf@197 PS1, Line 197: ul_earfcn: 20850 is this number here correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24042 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I7b2250e13fc1161be1a1d73a4348f07b31c0f724 Gerrit-Change-Number: 24042 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre <an...@softwareradiosystems.com> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 03 May 2021 10:15:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
