Hello vvvelichkov,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/gr-gsm/+/24068
to review the following change.
Change subject: grgsm_livemon: Change the type of several parameters to string
......................................................................
grgsm_livemon: Change the type of several parameters to string
It seems gnuradio 3.8 does not like parameters with type None and does
not put them as command line arguments
Change-Id: Id67e37e826aa1cc14640d57207a92def682f11e3
---
M apps/grgsm_livemon.grc
M apps/grgsm_livemon_headless.grc
2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/68/24068/1
diff --git a/apps/grgsm_livemon.grc b/apps/grgsm_livemon.grc
index 2f6d29c..4e07e88 100644
--- a/apps/grgsm_livemon.grc
+++ b/apps/grgsm_livemon.grc
@@ -105,7 +105,7 @@
hide: none
label: Device Arguments
short_id: ''
- type: ''
+ type: str
value: '""'
states:
bus_sink: false
@@ -178,7 +178,7 @@
hide: none
label: IP or DNS name of collector point
short_id: ''
- type: ''
+ type: str
value: 'localhost'
states:
bus_sink: false
@@ -195,7 +195,7 @@
hide: none
label: UDP port number of collector
short_id: ''
- type: ''
+ type: str
value: '4729'
states:
bus_sink: false
@@ -912,7 +912,7 @@
hide: none
label: UDP server listening port
short_id: ''
- type: ''
+ type: str
value: '4729'
states:
bus_sink: false
diff --git a/apps/grgsm_livemon_headless.grc b/apps/grgsm_livemon_headless.grc
index 4d0c83e..1bea77c 100644
--- a/apps/grgsm_livemon_headless.grc
+++ b/apps/grgsm_livemon_headless.grc
@@ -42,7 +42,7 @@
hide: none
label: Device Arguments
short_id: ''
- type: ''
+ type: str
value: '""'
states:
bus_sink: false
@@ -133,7 +133,7 @@
hide: none
label: IP or DNS name of collector point
short_id: ''
- type: ''
+ type: str
value: 'localhost'
states:
bus_sink: false
@@ -150,7 +150,7 @@
hide: none
label: UDP port number of collector
short_id: ''
- type: ''
+ type: str
value: '4729'
states:
bus_sink: false
@@ -804,7 +804,7 @@
hide: none
label: UDP server listening port
short_id: ''
- type: ''
+ type: str
value: '4729'
states:
bus_sink: false
--
To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/24068
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-Change-Id: Id67e37e826aa1cc14640d57207a92def682f11e3
Gerrit-Change-Number: 24068
Gerrit-PatchSet: 1
Gerrit-Owner: ptrkrysik <ptrkry...@gmail.com>
Gerrit-Reviewer: vvvelichkov <vvvelich...@gmail.com>
Gerrit-MessageType: newchange
