laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24159 )
Change subject: ts_102_221: fix unknown TLV key '9B' on SysmoSIM-SJS1 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/pysim/+/24159/1/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/24159/1/pySim/ts_102_221.py@186 PS1, Line 186: tlv_map['9B'] = 'unknown_9B' # found on SysmoSIM-SJS1; seems to mirror the file path Please call it sysmoUSIM-SJS1 in both the commit log and here. Theren were sysmoSIM-* cards, but not SJS1. Thanks. Please call the attribute 'target_ef'. It refers to linked files. Think of symlinks on a linux machine: you can have multiple directory entries pointing to the same file (e.g. from ADF.USIM/DF_GSM_ACCESS to files in DF_GSM. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8131bfbbdeb50ddb4d6a06c16586238a36582b5e Gerrit-Change-Number: 24159 Gerrit-PatchSet: 1 Gerrit-Owner: Falkenber9 <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Thu, 06 May 2021 16:24:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
