fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/24345 )
Change subject: gsm_data.h: fix wrong bit-mask in BSIC2BCC macro
......................................................................
gsm_data.h: fix wrong bit-mask in BSIC2BCC macro
BCC takes 3 LSB bits of the BSIC, so we should apply 0b111 or 0x07.
The BSIC is specified in 3GPP TS 03.03 section 4.3.2.
Change-Id: Id24ad64e6c6de080ab43faa272daf844fbba6954
Related: SYS#5315, OS#4940
---
M include/osmo-bts/gsm_data.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/include/osmo-bts/gsm_data.h b/include/osmo-bts/gsm_data.h
index ff0c89c..10bedcc 100644
--- a/include/osmo-bts/gsm_data.h
+++ b/include/osmo-bts/gsm_data.h
@@ -516,7 +516,7 @@
uint8_t gsm_lchan_as_pchan2chan_nr(const struct gsm_lchan *lchan,
enum gsm_phys_chan_config as_pchan);
-#define BSIC2BCC(bsic) ((bsic) & 0x3)
+#define BSIC2BCC(bsic) ((bsic) & 0x07)
uint8_t gsm_ts_tsc(const struct gsm_bts_trx_ts *ts);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24345
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: 2021q1
Gerrit-Change-Id: Id24ad64e6c6de080ab43faa272daf844fbba6954
Gerrit-Change-Number: 24345
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-MessageType: merged
