fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 )
Change subject: add bsc/BSC_Tests_VAMOS.ttcn ...................................................................... Patch Set 10: Code-Review-1 (5 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn File bsc/BSC_Tests_VAMOS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn@4 PS10, Line 4: * (C) 2017-2018 by Harald Welte <lafo...@gnumonks.org> Copyright: should be sysmocom, it's an entirely new file. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn@89 PS10, Line 89: var integer subslot; I would set it to 0, otherwise you may return an unbound value. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn@114 PS10, Line 114: var BIT5 rsl_cbits; Same here, one can easily get a DTE with this function. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn@135 PS10, Line 135: var BIT5 rr_cbits; + https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411/10/bsc/BSC_Tests_VAMOS.ttcn@158 PS10, Line 158: var boolean fr; + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c504099163a30ea102cbd26d3615ca2e5ce1e64 Gerrit-Change-Number: 24411 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 01 Jun 2021 02:12:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
