pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24272 )

Change subject: util: adds the feature to force the rpath when patching files.
......................................................................


Patch Set 1:

Hi, answering to your questions:

* I agree adding new param to change_elf_rpath sounds better than adding a new 
function

* I think it makes sense having different jenkins-build-*.sh script to build on 
different platforms. We do that for instance when building software we run in a 
sysmobts or OC2G BTS (armv5(?) each with its own yocto SDK and hence library 
versions), see jenkins-build-osmo-bts-* and jenkins-build-osmo-pcu-*.sh. The 
idea is to reuse as much as possible the -common.sh bits from the new file, ex 
jenkins-build-srslte-bbu.sh. You could add for instance a new global envvar 
PATCHELF_EXTRA_ARGS in -common.sh and then set it in 
jenkins-build-srslte-bbu.sh PATCHELF_EXTRA_ARGS="--force-rpath".

* Regarding LD_LIBRARY_PATH failing, it would be great to know why. Generally 
the way to find out is to ssh into the target host, then run the process 
manually: LD_LIBRARY_PATH="..." ./srsenb and see what it errors about. Also 
using ldd quickly tells you which is the library not being found: 
LD_LIBRARY_PATH="..." ldd ./srsenb. IIRC there's also some envvar you can set 
to tell the dynamic loader to enter debug mode and print lots of info.


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24272
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2d4a105d4843c0d31d6b5d8f8d4195247b290aec
Gerrit-Change-Number: 24272
Gerrit-PatchSet: 1
Gerrit-Owner: alealcon <alejandro.l...@srs.io>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Jun 2021 11:20:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to