fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24485 )

Change subject: [VAMOS] conf_lchans_as_pchan(): improve readability
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/24485/1/src/common/oml.c
File src/common/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24485/1/src/common/oml.c@824
PS1, Line 824:  } while(0)
> Hmm, it's just two lines wrapped into do-while and I am surprised that you 
> find it confusing. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24485
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1c5a033e89d9ca5fb01ebe9ffb521fd67d159bee
Gerrit-Change-Number: 24485
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: dexter <pma...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Fri, 04 Jun 2021 22:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: dexter <pma...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to