neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 )
Change subject: implement Channel Mode Modify to VAMOS mode ...................................................................... Patch Set 18: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2174 PS10, Line 2174: modify lchan > Agree with Harald here. Done https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2193 PS10, Line 2193: vty_out(vty, "Invalid sub-slot number for this timeslot type%s", VTY_NEWLINE); > Missing %% prefix. Done https://gerrit.osmocom.org/c/osmo-bsc/+/24374/10/src/osmo-bsc/bsc_vty.c@2198 PS10, Line 2198: vty_out(vty, "BTS does not support VAMOS%s", VTY_NEWLINE); > Missing %% prefix. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c Gerrit-Change-Number: 24374 Gerrit-PatchSet: 18 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:31:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
