pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24182 )
Change subject: mgcp_client: do not crash when lco/sdp can not be generated ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/24182/3/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/24182/3/src/libosmo-mgcp-client/mgcp_client.c@1352 PS3, Line 1352: rc_lco == -2 > Is there anything special about -2? I would just check if it's negative. Not > critical. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb788343e0bec9c0eaf33e6e4727d4d36c100017 Gerrit-Change-Number: 24182 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 08 Jun 2021 08:25:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
