alealcon has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24678 )
Change subject: util: fix the functions "create_netns" and "setcap_netsys_admin". ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24678/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24678/1//COMMIT_MSG@11 PS1, Line 11: - create_netns: pass "run_dir" to Process and convert the arguments to > ACK for the first. For the second, It's not really a fix since it works fine > anyway. […] It doesn't work. The local one uses the Process class, with the constructor def __init__(self, name, run_dir, popen_args, **popen_kwargs): and it needs the run_dir or it crashed because it mismatches the args with the run_dir. remote.py uses the RemoteProcess function with a different arguments: def RemoteProcess(self, name, popen_args, remote_env={}, **popen_kwargs): It's true that remote.py uses () instead [], but in utils.py almost all the methods use [], so I wanted to be consistent within that file. If you prefer () only for that function I can update the commit -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/24678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ida4c6d6500be92b8d1f96e4e7a870e63bd329be9 Gerrit-Change-Number: 24678 Gerrit-PatchSet: 1 Gerrit-Owner: alealcon <alejandro.l...@srs.io> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jun 2021 16:44:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
