Hello Jenkins Builder, I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-mgw/+/24941 to look at the new patch set (#4). Change subject: mgcp_protocol: refactor MGCP request handling ...................................................................... mgcp_protocol: refactor MGCP request handling At the moment the MGCP request handling and message parsing is not clearly separated. The function mgcp_parse_header() in mgcp_msg.c is also responsible for resolving an endpoint. This leads to unclear layer separation. We eventually end up in a situation where we can not execute any request handler without beeing able to resolve an endpoint, however this is necessary if we want to implement wildcarded DLCX resquests. In the current situation a wildcarded DLCX is not possible to implement as we always have to resolve a an to get to the trunk which we need to iterate. However, we just can't resolve a free endpoint in a situation where all endpoints on te trunk are in use. We have to refactor the request handler so that the parsing in mgcp_msg only extracts us the endpoint name. The resolving is then done in mgcp_handle_message() in mgcp_protocol.c. Then we are able to decide what to do if we are unable to resolve an endpoint but still be able to resolve the trunk. This patch does not change the behaviour of osmo-mgw yet, but it lays the foundation for request handler implementations that can still perform useful actions if no endpoint but a trunk has been resolved. A wilcarded DLCX is such a case. It does not need an endpoint, just the trunk. Change-Id: I9f519d8a0ee8a513fa1e74acf3ee7dbc0991cdde Related: SYS#5535 --- M include/osmocom/mgcp/mgcp_protocol.h M src/libosmo-mgcp/mgcp_msg.c M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_sdp.c 4 files changed, 187 insertions(+), 132 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/41/24941/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9f519d8a0ee8a513fa1e74acf3ee7dbc0991cdde Gerrit-Change-Number: 24941 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-MessageType: newpatchset