daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577 )
Change subject: gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1//COMMIT_MSG@12 PS1, Line 12: > I think unsolicited ACKs are typically ignored by many protocols. […] The spec only mentions ACKs for existing BVCs, it says nothing about ACKs for BVCs that we know nothing about. https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1/src/gb_proxy.c File src/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1/src/gb_proxy.c@1378 PS1, Line 1378: break; > it is indeed a bit inconsistent that an UNBLOCK_ACK or RESET_ACK are now > handled significantly diffe […] Agreed, I'll think about this more. Also the rate counter that is increased is completely wrong (invalid RAI, see comment below). I could keep a list of BVCIs that are gone (but were blocked towards the SGSN). Then we can ignore/accept only the BLOCK_ACKs that we care about and properly reject all others. https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577/1/src/gb_proxy.c@1497 PS1, Line 1497: rate_ctr_inc(rate_ctr_group_get_ctr(cfg->ctrg, GBPROX_GLOB_CTR_INV_RAI)); see here -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/25577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ic9f34a27412d6e15ca1198ee140f66a076b5c6b6 Gerrit-Change-Number: 25577 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Mon, 27 Sep 2021 12:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
