daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25629 )
Change subject: pdch: refactor rcv_control_ack() with a switch statement ...................................................................... Patch Set 1: (1 comment) The diff would have been easier to read if you kept the order between if and switch https://gerrit.osmocom.org/c/osmo-pcu/+/25629/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25629/1/src/pdch.cpp@350 PS1, Line 350: OSMO_ASSERT(ul_tbf); Could the ASSERT cause aborts where we would have only logged an error before (due to if ul_tbf and fall-through logging at the end)? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7e4a88d6e004bbb7974595320ed73742162c7ad7 Gerrit-Change-Number: 25629 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Tue, 28 Sep 2021 16:40:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
