fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25700 )
Change subject: Introduce gsm_lchan_release function helper ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/25700/2/include/osmo-bts/lchan.h File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/25700/2/include/osmo-bts/lchan.h@401 PS2, Line 401: rel_act_kind 'rel_kind' in this case. https://gerrit.osmocom.org/c/osmo-bts/+/25700/2/src/common/lchan.c File src/common/lchan.c: https://gerrit.osmocom.org/c/osmo-bts/+/25700/2/src/common/lchan.c@79 PS2, Line 79: struct gsm_lchan *lchan Can't we just pass 'struct gsm_bts_trx_ts *ts' directly? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0525beaba3c833f8d7adf9701fe373761a7720d3 Gerrit-Change-Number: 25700 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Thu, 07 Oct 2021 10:30:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
