pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25827 )
Change subject: Split csn1.c into common, enc and dec files ...................................................................... Patch Set 1: > Patch Set 1: > > I would say the other way around: first get this merged in wireshark and if > they accept it, "port" it over here? I actually was wrong here, because I recalled wireshark also had an encoding function despite it was not used. No porting is needed because actually wireshark code doesn't have the Encode function, hence they don't have this kind of problem. So actually having the Encoder function in a different file in our case I think actually helps when comparing against their code. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7d1b1f7e6d7f89b052b3fd73a960419bb2673020 Gerrit-Change-Number: 25827 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 19 Oct 2021 20:06:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
