laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 )
Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 4: Code-Review+1 I'm happy to merge the patch as it is an improvement. Howeve, I think a proper solution is to move all of that detection logic into the various CardProfile etc. classes. So the main application code of pySim-shell should really only call one (classmethod?) to perform autodetection aof card profiles, which would then iterate of all subclasses of CardProfile, call their autodetect method, which would do whatever it needs to do, etc. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 03 Nov 2021 12:02:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
