osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 )
Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 4: (1 comment) (clicking on start review to add a comment) https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py@85 PS4, Line 85: ; > Thanks! There is no way to have this in the linter? python does not complain > about it, so this goes […] you can install flake8 and put something like this in your pre-commit hook: flake8 --select E703 $(find -name '*.py') it will test for this, e.g.: ./test.py:15:74: E703 statement ends with a semicolon to add it to the linter that runs in gerrit, I've created: https://osmocom.org/issues/5292 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 05 Nov 2021 12:34:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
