fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 )
Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 1: > Patch Set 1: > > IMHO That should at least be a cmdline option, some programs may rely on > one-entry-per-line format (we need to check OGT). Something like > --enable-pretty-printing-json. This is still valid JSON, isn't it? Whitespace does not matter in JSON. The only thing I am worried about is the trailing comma, but some parsers do permit it. I guess you're using some parser in OGT rather than parsing the output manually? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 08 Nov 2021 13:16:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
