fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 )
Change subject: bts_pch_timer: Fix timer working only for MI type IMSI ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c File src/bts_pch_timer.c: https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c@37 PS2, Line 37: p->ptmsi != GSM_RESERVED_TMSI > I agree that in practice is not needed, but conceptually it makes to have it > here, since the ptmsi b […] AFAIK, conditional statements in a loop are the evil in terms of performance. So I would avoid redundant checks. Of course, it depends on how often this function gets called. Not gonna block, just sharing my thoughts. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4 Gerrit-Change-Number: 26166 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Nov 2021 18:45:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
