osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )
Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Nice api and well documented, LGTM https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h File include/osmocom/bsc/time_cc.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h@1 PS6, Line 1: /* Report the cumulative counter of time for which a flag is true as rate counter. */ Missing license header https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h@37 PS6, Line 37: * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a possible (This goes over 120 characters, so it wraps here in gerrit review for me. I think longer text comments are easier to read at less characters per line, so usually I ":set colorcolumn=80" for those.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 14:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
