laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 )
Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 3: (5 comments) https://gerrit.osmocom.org/c/pysim/+/26165/1/pySim/filesystem.py File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/26165/1/pySim/filesystem.py@1509 PS1, Line 1509: match_witch_card which, not witch. Halloween is over :P https://gerrit.osmocom.org/c/pysim/+/26165/1/pySim/filesystem.py@1511 PS1, Line 1511: dirived derived https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py@31 PS3, Line 31: _ you can simply use CardProfile.__subclasses__() which returns a list of all derived classes of CardProfile. This way it works automatically without having to manually maintain a list here. You also don't even need to import the CardProfileUICC... but a simple "import pySim.ts_102_221" should be sufficient, as then the code is loaded and the subclass is known. https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py@751 PS3, Line 751: match_witch_card still no witches or witchcraft involved :) I guess you meant "which" https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py@977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: why have this as a separate method outside of the class, only to wrap it into a @staticmethod below? You could just move this completely inside the @staticmethod below. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 11 Nov 2021 08:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
