dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 )
Change subject: pySim-shell: add method to match card profile to card ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py@31 PS3, Line 31: _ > you can simply use CardProfile. […] I don't think that it is so simple. The order matches. With __subclasses__() we get a random order. Also it seems to return only classes directly inherited from CardProfile, but the CardProfileUICCSIM is inherited from CardProfileUICC and does not appear in the list. import pySim.ts_102_221 did not work, but from pySim.ts_102_221 import * worked. However, if using __subclasses__() does not work its probably better to list the classes individually anyway. https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_102_221.py@751 PS3, Line 751: match_witch_card > still no witches or witchcraft involved :) I guess you meant "which" oops. I ment "with" https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py@977 PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool: > why have this as a separate method outside of the class, only to wrap it into > a @staticmethod below? […] I thought that this would help to make the actual class more readable because it is shorter then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691 Gerrit-Change-Number: 26165 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 11 Nov 2021 11:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
