fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 )
Change subject: ipaccess-config: improve readability of printed attribute response ...................................................................... Patch Set 2: Verified+1 > Patch Set 2: Code-Review+1 > > AFAIR pespin had some concerns about osmo-gsm-tester relying on existing > output, please do a grep in the osmo-gsm-tester repo to find out and make > sure it is updated, too. I checked the code, and as far as I can see we parse the output using Python's JSON library. I just fixed trailing commas in my code, so the parser is happy. I also did some tests, and everything appears to work fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876 Gerrit-Change-Number: 26149 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: roox <[email protected]> Gerrit-Comment-Date: Sat, 27 Nov 2021 23:14:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
