pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 )

Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report
......................................................................


Patch Set 1:

I'm not really convinced about this:
* You assume any program we run will have a talloc report on USR1
* I don't think it's necessary to print it by default each time, specially when 
not looking into it, since it adds stuff to the output (potentially long) which 
I'm not interested in and may cause confusion thinking some stuff crashed or 
similar.

So I'm fine with having it conditionally enabled by some param, or simply have 
it there commented out, so that if someone wants to check it cans simply 
uncomment those.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055
Gerrit-Change-Number: 26407
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 29 Nov 2021 09:48:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to