osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 )
Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 4: > Patch Set 3: > > > 3. firmware/libcommon/source/crcstub.c:16: ERROR:FSF_MAILING_ADDRESS: Do > > not include the paragraph about writing to the Free Software Foundation's > > mailing address from the sample GPL notice. The FSF has changed addresses > > in the past, and may do so again. Linux already includes a copy of the GPL. > > > > Personally I like if there is not so much boilerplate at the start of every > > file, and having the mailing address from the FSF in there in 2021 is > > probably not useful. So I'd argue it makes sense to remove the address. > > I'd argue that the comment block at the top is collapsed by any reasonable > editor anyway because no one wants to look at it - unless you create a new > file, by just copying the block from another open file. Then having to check > and modify that block because the linter looks at comments does not sound > like a improvement to me.. As discussed in the team meeting, I've removed the address from the source tree and this patch. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: tsaitgaist <[email protected]> Gerrit-Comment-Date: Tue, 14 Dec 2021 10:48:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
