Review at https://gerrit.osmocom.org/4643
mobile/gsm411_sms.c: use secure gsm_7bit_(en|de)code_n Since some 'gsm_7bit_*' functions were deprecated and replaced by more secure ones with the '_n_' postfix in names, it's better to use the updated functions. Change-Id: I58150e9b74699e5f54b9a83416ad8efcb2eccd8e --- M src/host/layer23/src/mobile/gsm411_sms.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/43/4643/1 diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c index 655fe53..f56262e 100644 --- a/src/host/layer23/src/mobile/gsm411_sms.c +++ b/src/host/layer23/src/mobile/gsm411_sms.c @@ -113,7 +113,8 @@ sms->data_coding_scheme = dcs; strncpy(sms->address, receiver, sizeof(sms->address)-1); /* Generate user_data */ - sms->user_data_len = gsm_7bit_encode(sms->user_data, sms->text); + sms->user_data_len = gsm_7bit_encode_n(sms->user_data, + sizeof(sms->user_data), sms->text, NULL); return sms; } @@ -282,7 +283,8 @@ switch (sms_alphabet) { case DCS_7BIT_DEFAULT: - gsm_7bit_decode(gsms->text, smsp, gsms->user_data_len); + gsm_7bit_decode_n(gsms->text, sizeof(gsms->text), + smsp, gsms->user_data_len); break; case DCS_8BIT_DATA: case DCS_UCS2: -- To view, visit https://gerrit.osmocom.org/4643 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I58150e9b74699e5f54b9a83416ad8efcb2eccd8e Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>