Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/4446/3/src/osmo-bts-octphy/main.c
File src/osmo-bts-octphy/main.c:

Line 58:        return 0;
I think if you introduce bts-specific command line options, you should also 
document them in the --help output.


-- 
To view, visit https://gerrit.osmocom.org/4446
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5774fbb29da832786326afb991014b9bd8b04b59
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to