pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26814 )
Change subject: socket, select: Fix -Wsign-compare warnings ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/select.c@319 PS1, Line 319: static int poll_disp_fds(unsigned int n_fd) it's a bit strange using an unsigned for an fd, it's usually an int right? https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/socket.c@213 PS1, Line 213: unsigned int i; this one should actually be a size_t afaiu. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idf6213e66e9bf609e930c6134292458a7d521871 Gerrit-Change-Number: 26814 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Mon, 10 Jan 2022 09:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
