pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792 )

Change subject: ranap_rab_ass: add decoder and rewrite functions for 
RAB-AssignmentRequest/Response
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/14/src/osmo-hnbgw/ranap_rab_ass.c
File src/osmo-hnbgw/ranap_rab_ass.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/14/src/osmo-hnbgw/ranap_rab_ass.c@198
PS14, Line 198: int ranap_rab_ass_req_extract_inet_addr(struct osmo_sockaddr 
*addr, uint8_t *rab_id, RANAP_RANAP_PDU_t *ranap_pdu)
> That is possible, but then the usage of those functions get more complicated 
> as caller then has to t […]
Not having to decode the same message N times.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I58b542bf23ff5e1db2ccf6833fec91d9ba332837
Gerrit-Change-Number: 26792
Gerrit-PatchSet: 15
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Mon, 17 Jan 2022 14:10:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: dexter <pma...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to