Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 18: (3 comments) File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/ea7db332_76340e25 PS14, Line 377: switch (ranap_pdu->choice.initiatingMessage.procedureCode) { > Checking with map->is_ps is not sufficient? Done File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/f23ec48f_73aec1a8 PS16, Line 379: mgw_fsm_handle_iu_release(map); > Is it expected that after handling IuRElease here, it is forwarded in > rua_tx_dt below? If so, please […] yes, this is expected. File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/a80b4922_9ee9a6cb PS16, Line 376: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg, > Why is this needed? I don't see a point for it. The msgb_resize_area shouldn't fail, but if it fails it is probably causes other problems that may be very difficult to detect. That is the reason for the OSMO_ASSERT -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26795 Gerrit-PatchSet: 18 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 02 Feb 2022 13:25:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
