Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27050 )
Change subject: add osmo_sockaddr_from/to_octets() ...................................................................... Patch Set 1: (2 comments) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/27050/comment/6219a76d_73d46bb7 PS1, Line 1746: size_t l; > use len if possible, my eyes hurt seeing number ones everywhere due to l and > 1 looking similar :P lol, right =) https://gerrit.osmocom.org/c/libosmocore/+/27050/comment/2a9ad3b4_40990b28 PS1, Line 1747: switch (os->u.sin.sin_family) { > os->u.sa. […] i'm still confused with all the different sockaddrs, thx -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27050 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie9e33bfac525c59c30714663d2bfcc62ec9eeb81 Gerrit-Change-Number: 27050 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 07 Feb 2022 21:14:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
