Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )
Change subject: Add hnbgw test ...................................................................... Patch Set 1: Code-Review+1 (6 comments) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/6c9d5bae_4ccb36e0 PS1, Line 212: /*function f_start_handler(void_fn fn, template (omit) TestHdlrParams pars := omit) Can this be dropped? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/e255ea6a_b4c07824 PS1, Line 218: /*private function f_tc_hnb_register_request(charstring id) runs on HNBGW_ConnHdlr { Can this be dropped? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/9d7c5b0d_aef95501 PS1, Line 224: //var HNBGW_ConnHdlr vc_conn; Can this be dropped? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/470bbd3b_c5af69f9 PS1, Line 247: //var HNBGW_ConnHdlr vc_conn; Can this be dropped? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/e604765e_e50cd735 PS1, Line 267: //RANAP.receive(); Can this be dropped? File hnbgw/MSC_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/e996cb9f_48d1fe87 PS1, Line 96: // FIXME FIXME what? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a2fb795aec83337eda8d9972e6ff264ead61076 Gerrit-Change-Number: 27106 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Thu, 10 Feb 2022 12:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
