Attention is currently required from: iedemam, daniel.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/27137 )

Change subject: stats: sanitize tcp stat name identifiers
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> There is no sanitation in osmo_stat_item_group_set_name(). […]
What's strange to me then is why don't we have already some sort of API to 
sanitize string so that the resulting string is a valid statsd string. That 
would be helpful, because there can be lots of chars which are not accepted.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2
Gerrit-Change-Number: 27137
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: iedemam <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Fri, 11 Feb 2022 12:04:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to