Attention is currently required from: neels. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: WIP: New stats for lchan life duration. ...................................................................... Patch Set 9: (11 comments) Patchset: PS9: Hi Neels, Thanks for the extensive review. I have addressed many of your individual comments but not yet made the switch to your recommended approach for increasing accuracy. I will submit another update tomorrow. For now, I wanted to clean up the noise on this changeset so far and clarify its purpose. Thanks again, -Michael File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/9d9705a8_8f4ae15f PS8, Line 1130: unsigned long long gsm_lchan_active_duration_ms(const struct gsm_lchan *lchan); > (idea: use uint64_t for a fixed size independent from arch. […] Done File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/71d1a3aa_870a5141 PS8, Line 1514: "Cummulative number of active milliseconds on TCH chans", > ("Cumulative") […] I agree the name is messy. However, this will indeed hold the cumulative number of milliseconds, not the average duration per activation. I am deriving the average based on this total in the VTY. I am also planning to use this total to show Erlangs per site. Perhaps "Cumulative number of milliseconds of TCH channel activity."? File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/30f5d6cc_d4f24e9b PS8, Line 574: uint duration_s = (gsm_lchan_active_duration_ms(lchan) + 500) / 1000; > the +500 acts as a round(), yet the reported descriptions below suggest that > floor() should be used […] Done File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/6d99f3ed_038fd742 PS8, Line 3826: uint64_t activations_tch = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_ACT_TCH)->current; > osmocom style dictates that local variables are declared at the start of the > function (or scope) Done File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/a2e11d99_13e44cab PS8, Line 348: /* Get duration of active time for this lchan in milliseconds */ > Rather: […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/273efcdf_40c620a0 PS8, Line 352: if (lchan->activate.concluded) { > osmocom style asks for early-exit: […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/e7f20f1a_ff1fca66 PS8, Line 357: duration = elapsed.tv_sec * 1000LL + elapsed.tv_nsec / 1000000; > the LL on the 1000 has no effect, the first operand defines the integer size > for calculation. […] Done File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/0de12fcb_1e7b022d PS8, Line 1810: > You should rather put this bit in a new lchan_st_established_onleave() > function. […] This is a great bit of information. I do think it is important to capture the error timeouts. If we see SDCCH averages trending toward a long timeout value, we know something is up. I've moved the stat increment code and log to lchan_fsm_unused_onenter. https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/2de06a3f_096d9a4e PS8, Line 1811: /* Add active milliseconds to cummulative counts per channel type */ > /* Report how long this lchan was active, to add to the average activity > duration metric. […] Adopted. However, I will use "cumulative duration" to reflect that stat's purpose as mentioned before. https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/d1cd083c_5099ffff PS8, Line 1817: LOG_LCHAN(lchan, LOGL_INFO, "GSM_LCHAN_TCH was active for %llu milliseconds\n", duration_ms); > i would rather just have a single LOG_LCHAN() that uses gsm_chan_t_name() > above the switch, because […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 9 Gerrit-Owner: iedemam <mich...@kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Mon, 21 Feb 2022 18:13:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
