Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 27: Code-Review+1 (4 comments) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/54534cfb_7099f6d0 PS25, Line 52: /* Send Iu Release request, this is done in errornous cases from which we cannot recover */ > I don't understand. typo: errornous-> erroneous https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/2a12365f_58927be2 PS25, Line 53: static void tx_release_req(struct hnbgw_context_map *map) > Do you have any ideas where? This is a helper function that is called from to > location of this FSM t […] We'd probably want to add a hnbgw_iu.c or alike, but ok, let's keep it here for now. https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/0b656f0c_de71297b PS25, Line 424: rc = msgb_resize_area(mgw_fsm_priv->ranap_rab_ass_resp_oph->msg, > In practice the message don't change ths size, but in theory they might > either shrink or grow. […] ack https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/821e89d6_4ca62ba0 PS25, Line 627: static int handle_rab_release(struct hnbgw_context_map *map, struct osmo_prim_hdr *oph, ranap_message *message) > It does belong to here. […] Ok let's leave it here for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26795 Gerrit-PatchSet: 27 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Feb 2022 16:36:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
