neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27085 )
Change subject: follow-up to osmo_sockaddr_from/to_octets() ...................................................................... Patch Set 1: (1 comment) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/27085/comment/0083e9ff_b2a3026a PS1, Line 1779: os->u.sa.sa_family = AF_INET; > This should have been kept as os->u.sin. […] yes, i understand and agree, apparently i wasn't paying close attention to that -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id202f3fda51bea9149ab3462a2efe35cf08d8030 Gerrit-Change-Number: 27085 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 Mar 2022 12:03:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment