Patch Set 1: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/#/c/4750/1/src/libfilter/bsc_msg_filter.c
File src/libfilter/bsc_msg_filter.c:

Line 194:               if (bsc_msg_acc_lst_check_allow(nat_lst, imsi) == 0)
sure we can do it.


Line 208:       return 1;
But that was "the global allow". So It might make sense to have an access-list 
define a default?


-- 
To view, visit https://gerrit.osmocom.org/4750
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb6c8dd62aa90666ba6fcd213f59d79f5498da3f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Holger Freyther <hol...@freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to