Attention is currently required from: pespin.
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/27606 )

Change subject: mgcp_network: do not try to convert RTCP packets
......................................................................


Patch Set 2:

(2 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/8c8f6a18_ff044230
PS1, Line 1514:         rc = rx_rtp(msg, proto);
> proto is already available in mc (which is contained in msg). No need to pass 
> it as param.
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/43e37214_7ad20195
PS1, Line 1537:         if (proto == MGCP_PROTO_RTP && 
amr_oa_bwe_convert_indicated(conn_src->end.codec)) {
> mc = OSMO_RTP_MSG_CTX(msg); […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b
Gerrit-Change-Number: 27606
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Mar 2022 14:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to