Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4715
to look at the new patch set (#2).
cosmetic: add comment on ignored return value
Coverity wants us to evaluate sqlite3_reset, but it is of no use to do so.
Related: coverity CID#178653
Change-Id: I64ac8c148f48be60f9c0d346df0c5152bb527494
---
M src/db.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/15/4715/2
diff --git a/src/db.c b/src/db.c
index 8733cf5..d16f8ec 100644
--- a/src/db.c
+++ b/src/db.c
@@ -99,6 +99,8 @@
void db_remove_reset(sqlite3_stmt *stmt)
{
sqlite3_clear_bindings(stmt);
+ /* sqlite3_reset() just repeats an error code already evaluated during
sqlite3_step(). */
+ /* coverity[CHECKED_RETURN] */
sqlite3_reset(stmt);
}
--
To view, visit https://gerrit.osmocom.org/4715
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64ac8c148f48be60f9c0d346df0c5152bb527494
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
