pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/27635 )
Change subject: ms: Remove unneeded bts!=NULL check
......................................................................
ms: Remove unneeded bts!=NULL check
The ms_alloc function is expected to always have a proper bts object
passed, since an ms is always attached at a BTS.
Change-Id: I10b3c94dcb2fed4bff40b1ab7ea455175cf77ce4
---
M src/gprs_ms.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
lynxis lazus: Looks good to me, approved
diff --git a/src/gprs_ms.c b/src/gprs_ms.c
index 3167dee..63f454f 100644
--- a/src/gprs_ms.c
+++ b/src/gprs_ms.c
@@ -90,6 +90,7 @@
struct GprsMs *ms_alloc(struct gprs_rlcmac_bts *bts, uint32_t tlli)
{
struct GprsMs *ms = talloc_zero(tall_pcu_ctx, struct GprsMs);
+ OSMO_ASSERT(bts);
talloc_set_destructor(ms, ms_talloc_destructor);
@@ -116,8 +117,7 @@
ms_set_mode(ms, GPRS);
- if (ms->bts)
- codel_interval = the_pcu->vty.llc_codel_interval_msec;
+ codel_interval = the_pcu->vty.llc_codel_interval_msec;
if (codel_interval != LLC_CODEL_DISABLE) {
if (codel_interval == LLC_CODEL_USE_DEFAULT)
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27635
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I10b3c94dcb2fed4bff40b1ab7ea455175cf77ce4
Gerrit-Change-Number: 27635
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
