Patch Set 1: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/4714/1/src/libvlr/vlr_auth_fsm.c File src/libvlr/vlr_auth_fsm.c: Line 592: if (!afp) { > Oh wait, fi is a child FSM, isn't it going to be cleaned up from the parent iyes, you are right. migt still be good to do it explicit or to have a comment here about it, but it's not all that important. -- To view, visit https://gerrit.osmocom.org/4714 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d1c15b546377b1afa38f7f40c5421b743e21605 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
