Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27972 )
Change subject: abis_nm: add bts model features to reported ones ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27972/comment/42e004a9_bbf6dacf PS1, Line 620: for (i = 0; i < _NUM_BTS_FEAT; i++) { > if bts->type == GSM_BTS_TYPE_NANOBTS Done https://gerrit.osmocom.org/c/osmo-bsc/+/27972/comment/bf71f1ee_db8fd8bc PS1, Line 621: if (!osmo_bts_has_feature(&bts->model->features, i) || /* intentional check against bts model */ > This early continue is difficult to understand, I had to turn ir around to > understand it. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7bdbf28c148877275048e070dce7f503ca5e6226 Gerrit-Change-Number: 27972 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 28 Apr 2022 14:16:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
