pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28040 )
Change subject: nm_is_running(): Drop duplicate check
......................................................................
nm_is_running(): Drop duplicate check
NM_AVSTATE_OK is 0xff, so we are checking twice against same value.
Change-Id: Idac56e5eca2b6f6998195ec764fac7edbc8f53e2
---
M src/osmo-bsc/gsm_data.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/28040/1
diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index de298a8..3438eaf 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -760,7 +760,7 @@
bool nm_is_running(const struct gsm_nm_state *s) {
if (s->operational != NM_OPSTATE_ENABLED)
return false;
- if ((s->availability != NM_AVSTATE_OK) && (s->availability != 0xff))
+ if (s->availability != NM_AVSTATE_OK)
return false;
if (s->administrative != NM_STATE_UNLOCKED)
return false;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28040
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idac56e5eca2b6f6998195ec764fac7edbc8f53e2
Gerrit-Change-Number: 28040
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-MessageType: newchange
