Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28046 )
Change subject: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc ...................................................................... Patch Set 5: (2 comments) File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/9f5a3181_ec64f309 PS2, Line 56: } > the point is if teh function is prefixed nm_obj_* and you don't want to > change the function name, th […] nm_obj here is used in the sense of "The NM Object this FSM is handling", which is a bb_transc in this case. So it's based on the context of the current FSM, the function is static/internal/private after all. There's no such "struct nm_obj" at all. This way when these functions are used in each FSM state function, they look a lot similar, so it's easy to follow the FSM logic more easily, and see that all basically do the same, each on the NM object they are managing. But if this really causes trouble to you I'll change the name and be done with it, though I really prefer it the way it is now. File src/osmo-bsc/nm_rcarrier_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/823c57a8_232e1431 PS2, Line 43: static void nm_obj_becomes_enabled_disabled(struct gsm_bts_trx *trx, bool running) > then pass some generic object and have the called function use > gsm_objclass2obj() to de-reference th […] ACK I'll change the function name. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I206d4c7863a77fbab6a600126742a6a6b8fc3614 Gerrit-Change-Number: 28046 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 13 May 2022 10:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
