Attention is currently required from: iedemam.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28200 )

Change subject: performance: only track "all_allocated" states in one-second 
intervals
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
This is fine as a quick hotfix.
I have a proper fix almost ready in osmo-bsc branch neels/perf.

The problem with this patch is that periodic updating of the all_allocated 
flags suffers
from undersampling effects and likely makes those stats far less reliable.
We need immediate updating of the all_allocated flags, and we can do it without 
iteration.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28200
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idffd8792eecb7f13812f2c3b3bee5485e9c3f409
Gerrit-Change-Number: 28200
Gerrit-PatchSet: 1
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Attention: iedemam <[email protected]>
Gerrit-Comment-Date: Sat, 28 May 2022 21:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to