Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-upf/+/28245 )

Change subject: install libosmo-gtlv, libosmo-pfcp
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS1:
> It is a difficult question, and as neels has pointed out, one that has not 
> really been properly reso […]
AFAIU this library (PFCP) can also be used by someone wishing to implement a 
osmo-smf, so having to pull in the whole osmo-upf (now it may be simple, but in 
the future it can become a complex beast implementation depending on strange 
stuff having to move high loads).

Specially in the libgtp/ggsn, it's really weird having to depend on 
osmo-ggsn.git from osmo-sgsn.git, which is something I'd really want to avoid 
having again.

To me all this looks more like repeating errors from the past. Those are my 
five cents, I'm not blocking this, go merge if you wish.



--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28245
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I9f4651b6bee457583aba99052dc82bbf675515e6
Gerrit-Change-Number: 28245
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Fri, 10 Jun 2022 09:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to