Attention is currently required from: laforge.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28256 )

Change subject: Move all SMSCB/CBC vty code to its own file
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> is this purely cosmetic? might deserve a mention in the commitlog. […]
Because I had to learn the code, and having 1k lines less of boilerplate code 
to look at is really helpful to understand it quicker. This is useful for me 
now and other people coming later.
Also, because in general we put VTY code in _vty.c files.

And yes, this commit is purely cosmetic, moving stuff around.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifc7d1693d745dd2a3c31e3ee9610d8c634b50812
Gerrit-Change-Number: 28256
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Fri, 10 Jun 2022 09:47:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to