osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28257 )

Change subject: Cosmetic: bsc_vty: tweak msc pooling strings
......................................................................

Cosmetic: bsc_vty: tweak msc pooling strings

Drop "to this MSC" from the NRI_STR, as it is not only used for MSC
specific configuration, but also in cfg_net_nri_* which affect all MSCs.

Drop "for this MSC" from the description of cfg_net_nri_null_del, it
affects all MSCs (unlike cfg_msc_nri_del).

Change-Id: Ic8888775a965b6d607af51b9359bd8ffc2834e16
---
M src/osmo-bsc/bsc_vty.c
M tests/nri_cfg.vty
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index fc03c78..fb03d6f 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -1148,7 +1148,7 @@
        return CMD_SUCCESS;
 }

-#define NRI_STR "Mapping of Network Resource Indicators to this MSC, for MSC 
pooling\n"
+#define NRI_STR "Mapping of Network Resource Indicators, for MSC pooling\n"
 #define NULL_NRI_STR "Define NULL-NRI values that cause re-assignment of an MS 
to a different MSC, for MSC pooling.\n"
 #define NRI_FIRST_LAST_STR "First value of the NRI value range, should not 
surpass the configured 'nri bitlen'.\n" \
        "Last value of the NRI value range, should not surpass the configured 
'nri bitlen' and be larger than the" \
@@ -1195,7 +1195,7 @@
 DEFUN_ATTR(cfg_net_nri_null_del,
           cfg_net_nri_null_del_cmd,
           "nri null del <0-32767> [<0-32767>]",
-          NRI_STR NULL_NRI_STR "Remove NRI value or range from the NRI mapping 
for this MSC\n"
+          NRI_STR NULL_NRI_STR "Remove NRI value or range from the NRI 
mapping\n"
           NRI_FIRST_LAST_STR,
           CMD_ATTR_IMMEDIATE)
 {
diff --git a/tests/nri_cfg.vty b/tests/nri_cfg.vty
index e8dec5a..8e935a4 100644
--- a/tests/nri_cfg.vty
+++ b/tests/nri_cfg.vty
@@ -121,7 +121,7 @@

 OsmoBSC(config-net)# nri null ?
   add  Add NULL-NRI value (or range)
-  del  Remove NRI value or range from the NRI mapping for this MSC
+  del  Remove NRI value or range from the NRI mapping

 OsmoBSC(config-net)# nri null add ?
   <0-32767>  First value of the NRI value range, should not surpass the 
configured 'nri bitlen'.

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28257
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic8888775a965b6d607af51b9359bd8ffc2834e16
Gerrit-Change-Number: 28257
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged

Reply via email to