Attention is currently required from: neels, laforge, pespin, fixeria, dexter.
iedemam has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/28276 )

Change subject: Expand VTY option which controls use of TCH for signalling
......................................................................


Patch Set 5:

(2 comments)

File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/65277dc1_14f22274
PS4, Line 524: chan_alloc_allow_tch_for_signalling
> cosmetic: I'd rename it to "tch_for_signalling_policy" or something like that 
> which makes it more cl […]
Done


File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/f1bfae62_997c3ccd
PS4, Line 568: DEFUN_ATTR
> it might be nice to add a backwards-compatibility alias for the (0|1) so old 
> config files still pars […]
Agreed. This should be in place already, perhaps I've not gotten it correct 
though.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640
Gerrit-Change-Number: 28276
Gerrit-PatchSet: 5
Gerrit-Owner: iedemam <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 14 Jun 2022 20:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to