Attention is currently required from: osmith.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 )

Change subject: bssap_conn: fix missing length check
......................................................................


Patch Set 1:

(1 comment)

File src/osmo-bsc-nat/bssap_conn.c:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/0d3ec994_ea60a79a
PS1, Line 48:           if (rv < 0 || len > UINT_MAX) {
I don't think len can ever be higher than UINT_MAX. That's mean you are in an 
architecture of 8bit integers..



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db
Gerrit-Change-Number: 28582
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Tue, 12 Jul 2022 13:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to